Improve exception handling #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test will fail for now showing the shortcomings of trying to tokenize the while at once. Signed-off-by: Gilles Dartiguelongue <gilles.dartiguelongue@esiee.org>
Leave a chance to detect the headers even if the content of the file does not validate against Python tokenizer. Signed-off-by: Gilles Dartiguelongue <gilles.dartiguelongue@esiee.org>
Signed-off-by: Gilles Dartiguelongue <gilles.dartiguelongue@esiee.org>
EvaSDK
force-pushed
the
improve_exception_handling
branch
from
c86a51c to
0e93b4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I tried to use this on a new project and had issues due to the code trying to tokenize whole files instead of yielding the content as it comes. Here is a proposal fixing the problem still making sure an exception will still behave properly.