EN_NZHolidayStrategy: added Matariki and fixed 2011 Easter-Anzac clash#230
Merged
joaomatossilva merged 3 commits intojoaomatossilva:masterfrom Feb 11, 2025
Merged
EN_NZHolidayStrategy: added Matariki and fixed 2011 Easter-Anzac clash#230joaomatossilva merged 3 commits intojoaomatossilva:masterfrom
joaomatossilva merged 3 commits intojoaomatossilva:masterfrom
Conversation
Contributor
b-h-mck
commented
Feb 10, 2025
b-h-mck
commented
- Added Matariki as a public holiday in New Zealand. Unfortunately it's a floating holiday with no readily-available algorithm, so I added it as a year map from 2022 (when it started) to 2035.
- Fixed (and added unit tests for) a bug where the NZ culture would crash for 2011 dates. This was happening because Easter Monday and Anzac Day were on the same day that year, and NZ legislation doesn't allow for any shifting in that scenario. I fixed it by combining them into a single holiday with both names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.