Move copy button and update generate button#867
Move copy button and update generate button#867NotMyFault wants to merge 1 commit intojenkinsci:masterfrom
Conversation
jtnord
left a comment
jtnord
left a comment
There was a problem hiding this comment.
aside from the inline comments the buttons are not vertically aligned - the copy button is quite a bit higher than the generate button.
This could be an issue in the Jenkins styles, or in the layout used here.
I am +0 on the moving of the button. In one hand it means once you know the flow there is less need to move the mouse (or tab), on the other your eyes would normally click the button, then scan the text so your eyes would be at the bottom of the textarea.
| data-url="${rootURL}/${it.GENERATE_URL}"/> | ||
| <button class="jenkins-button jenkins-button--primary" id="generatePipelineScript" | ||
| data-url="${rootURL}/${it.GENERATE_URL}">${%Generate Pipeline Script}</button> | ||
| <nbsp/> |
There was a problem hiding this comment.
? if we need to wrap this button and the copy button does the UI not have more issues than this?
Does this even need a space, as the margin-left has been specified?
| <button class="jenkins-button jenkins-button--primary" id="generatePipelineScript" | ||
| data-url="${rootURL}/${it.GENERATE_URL}">${%Generate Pipeline Script}</button> | ||
| <nbsp/> | ||
| <l:copyButton text="" tooltip="${%Click to copy}" clazz="jenkins-!-margin-left-2"/> |
There was a problem hiding this comment.
this is now shown when there is nothing to copy - which seems like a UX issue (either the button should be hidden as now until the script has been generated, or the button should be disabled until there is something to copy)?
|
(merge conflicts) |
3 participants
The change proposed moves the "copy to clipboard" button above the output box, matching with other buttons' locations.
Additionally, I've changed the generation button from YUI to make use the Jenkins button layout:
Before:
After:
