[JENKINS-54514] Document error handling in the 'parallel' step

[ringerc]

JENKINS-54514

[ringerc]

The checks failed due to what appears to be network issues with the Windows builder.

[jglick]

Thanks!

[bitwiseman]

@ringerc What do you think of the suggestions?

[ringerc]

I appreciate the review and will merge the changes and update the PR shortly. I've been swamped at work.

…

On Sat, 15 Jun 2019 at 07:43, Liam Newman ***@***.***> wrote: @ringerc <https://github.com/ringerc> What do you think of the suggestions? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#260?email_source=notifications&email_token=AACC7IMVFFTTKTFGTYI4MGLP2QUKVA5CNFSM4GCJZWIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXYK2VA#issuecomment-502312276>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACC7IJFGHBBTIKEDW33G3TP2QUKVANCNFSM4GCJZWIA> .

-- Craig Ringer http://www.2ndQuadrant.com/ 2ndQuadrant - PostgreSQL Solutions for the Enterprise

[bitwiseman]

@ringerc Any update here? I'd apply the commits myself but I don't have permissions. I'd like to be able to merge this change.

[nickoe]

@ringerc @bitwiseman It looks like this has been lost in time.

[dwnusbaum]

Added some comments. It would be great to also apply Jesse's comments/suggestions.

[dwnusbaum]

AbortException is not necessarily thrown by failing steps.

I think mentioning AbortException is misleading since it doesn't have any special interaction with the parallel step.

[dwnusbaum]

I would move this paragraph above the preceding one, and reword it slightly. Since we don't want anyone to rely on the current behavior I think it is best not to mention what that behavior is directly.

      Note: Branch closures should just return <code>null</code>. The return
      value of the <code>parallel</code> step should be ignored; See JENKINS-26033.