Params comparison instrumentation #76
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ingOnNode() : log on which node we have a hit
…ingOnNode() : log the itemParams we compare to too
…check fail (some or all actual params not hit by filter)
…ingOnNode() : log the params arrays before and after doFilter()ing
…o paramsToCompare for readability
…ility and update some comments
…spam in FINE level
jimklimov
force-pushed
the
params-compare-instrumentation
branch
from
d40bbd4 to
63af186
Compare
Contributor
Author
|
Updated for minor conflicts after #75 was merged |
Member
|
@jimklimov Is there still a strong motivation to finish and merge this PR? I'm not sure if this is still useful or if it has outlived its purpose after it was used to successfully debug previous issues. If it is still needed, I'm concerned about the cost of the string concatenation for all the fine log statements. This is a hot code path in Jenkins, so any extra overhead here is a bit of a risk. The traditional best practice for this in Java is to guard such string concatenation with e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @basil asked, here is another presumably not problematic subset of #59 that adds logging instrumentation in the code going through build parameter filtering. Due to the split of PRs, there may be a little formatting conflict vs. #75 that is another part of that original wad of code, and vs. subsequent PR with actual attempt at the fix.