Skip to content

Conversation

@oleg-nenashev
Copy link
Member

The approach is not ready (see the idea in #27 ).

  • It provides some performance advantages on overloads in "categories" mode, but I'm still able to overload Jenkins.
  • Job configuration updates should be handled. Currently cache may become inconsistent if somebody adds/removes configurations to jobs during their execution

Merge with #27 is also required

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a bad idea from another commit. I'll rework it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type can be omitted BTW

@jglick
Copy link
Member

jglick commented Apr 16, 2015

Merging with #27 will be hard. Probably you could just merge the first three commits, but the fourth (Snapshot) would need to be recreated.

This seems risky: code mistakes or oversights could easily lead to a stale cache.

@oleg-nenashev
Copy link
Member Author

This seems risky: code mistakes or oversights could easily lead to a stale cache.

Yes, I'm also aware about it. I consider flushing the cache on updates and other conditions. There's still a risk of false-negatives deadlock if something is implemented incorrectly. Probably, a periodic cache cleanup (e.g. every 1 minute) could prevent it

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@oleg-nenashev oleg-nenashev changed the title [WiP] - TCB plugin performance (extra caching) [WiP] [JENKINS-27650] - TCB plugin performance (extra caching) Apr 17, 2015
@jglick jglick changed the title [WiP] [JENKINS-27650] - TCB plugin performance (extra caching) [JENKINS-27650] TCB plugin performance (extra caching) Jan 4, 2016
@basil
Copy link
Member

basil commented Dec 13, 2019

@oleg-nenashev The last update to this PR was 4 years ago. Can this PR be closed to clean up the open pull requests list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants