Skip to content

Conversation

@strangelookingnerd
Copy link
Contributor

This PR aims to migrate all tests to JUnit5. Changes include:

  • Migrate annotations
  • Migrate assertions
  • Minor cleanup
  • Remove public visibility of test classes and methods
  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

* Migrate annotations and imports
* Migrate assertions
* Remove public visibility for test classes and methods
* Minor clean up
@strangelookingnerd strangelookingnerd requested a review from a team as a code owner February 14, 2025 14:04
@strangelookingnerd
Copy link
Contributor Author

@jenkinsci/text-finder-plugin-developers Kindly requesting a review.

@basil
Copy link
Member

basil commented Jun 26, 2025

I would prefer to wait until jenkinsci/throttle-concurrent-builds-plugin#302 (review) is addressed before migrating my plugins to JUnit 5. That way, if any API changes are needed in order to address that comment, I would only need to perform them once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants