Skip to content

Only use crumbIssuer if needed#556

Open
sboardwell wants to merge 1 commit intojenkinsci:masterfrom
sboardwell:only-use-crumb-if-needed
Open

Only use crumbIssuer if needed#556
sboardwell wants to merge 1 commit intojenkinsci:masterfrom
sboardwell:only-use-crumb-if-needed

Conversation

@sboardwell
Copy link

This PR removes unneccessary requests to the /crumbIssuer endpoint when using an API token.

  • the decision of whether a crumb is needed is made at agent creation time
  • subsequent calls to sync labels, etc, request the crumb only if needed

Testing done

  • Tested both manually and through adding a test case

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@sboardwell sboardwell marked this pull request as ready for review May 2, 2023 16:37
@sboardwell sboardwell requested a review from a team as a code owner May 2, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant