Skip to content

SuppressFBWarnings for switch-case #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asimell merged 1 commit into from
Oct 14, 2025
Merged

SuppressFBWarnings for switch-case #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/hudson/plugins/robot/RobotParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/
package hudson.plugins.robot;

import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import hudson.AbortException;
import hudson.FilePath;
import hudson.Util;
Expand Down Expand Up @@ -469,6 +470,7 @@
return stackTrace.toString();
}

@SuppressFBWarnings("SF_SWITCH_FALLTHROUGH")
private String processKeyword(XMLStreamReader reader, int nestedCount) throws XMLStreamException {
StringBuilder stackTrace = new StringBuilder();
String kw = reader.getAttributeValue(null, "name");
Expand All @@ -485,6 +487,7 @@
case "arguments":
case "arg":
stackTrace.append(processArgs(reader));
// TODO: Refactor processArgs, so it won't return <kw> element and we can break out of this switch case normally and remove the SuppressFBWarnings above

Check warning on line 490 in src/main/java/hudson/plugins/robot/RobotParser.java

View check run for this annotation

ci.jenkins.io / Open Tasks Scanner

TODO 

NORMAL:
Refactor processArgs, so it won't return
element and we can break out of this switch case normally and remove the SuppressFBWarnings above
continue; // processArgs returns with us already in <kw>. We don't want to use reader.next()
case "for":
case "while":
Expand Down
Loading