-
Notifications
You must be signed in to change notification settings - Fork 85
Option to handle test reports by Artifact Manager #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to handle test reports by Artifact Manager #89
Conversation
|
Hi @asimell |
|
I'm currently on parental leave, so I don't have that much free time to review PRs as I do when I'm at work. I asked @Tattoo if he could review this, but he's also busy for a few weeks. This PR also has quite a few changes, so the review and testing will take a bit more time. Especially since Artifact Manager is not something I actively use. In general, I like the addition, but I need to squeeze in time for the review from somewhere somehow. I'm sorry I can't actually give an accurate ETA right now. I hope you understand. But just to give you an answer, I'll say I can try to review it during September. |
|
Hi @Tattoo and @asimell |
|
@olegmaiboroda-lab49 hi, sorry for the delay. I'll try to find time for this during this or next week. After it's merged it shouldn't take long to release. |
asimell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Tattoo any comments from you?
|
Hi @asimell. Thanks for merging this FB! |
|
Hi @olegmaiboroda-lab49, there's still #88 pending. CI build failed for that so I need to double check it's not related to the PR. I'll make the release when everything is merged and passing. |
|
I'm very sorry for being annoying. As I can see #88 is merged. How far we are from the release now? |
|
6.2.0 was released last week. |
Currently, the plugin copies Robot Framework output files to the build directory. The purpose of this change is to implement an option that allows the plugin to treat test report files as artifacts and delegate the task of saving them to a configured in the system Artifact Manager.
Testing done
A significant part is covered by existing and added automated tests.
Also the manual testing is done on my AWS machine.
Submitter checklist
1. useArtifactManager boolean option added
2. RobotPublisher changed to archive test results by Artifact Manager if useArtifactManager == true. Otherwise original logic is intacted.
3. Corresponded links are modified to point to artifactory location if useArtifactManager == true.
Not quite the same, but related request: https://issues.jenkins.io/browse/JENKINS-71096