Add remote host binding for JenkinsRule #289
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fr123k
force-pushed
the
fr/add_remote_host_support
branch
2 times, most recently
from
e6646b6 to
580910c
Compare
The reason for this change is that the JenkinRule based tests were all running inside a docker container and i needed a way to bind it a non localhost address in order to access it from outside the running container. The host binding for the JenkinsRule is configurable with the `host` property. The default value is `localhost` this keeps the backward compatibility. The following code snippet shows how to bind the JenkinsRule instance ``` @rule public JenkinsRule j = new JenkinsRule() {{ host = null; } }; ``` to all network interfaces. This is similar to set the `host` value to `0.0.0.0`. The test case `JenkinsRuleHostIPTest` validates that the assignment to a specific host ip address is working correctly. The test case `JenkinsRuleAllHostInterfaceTest` validates that the assignment to all network interfaces is working correctly.
fr123k
force-pushed
the
fr/add_remote_host_support
branch
from
580910c to
8f860d2
Compare
Member
|
This is basically #84 I think, and is potentially problematic for the same reason. See https://github.com/jenkinsci/kubernetes-plugin/blob/55e01eaca472ddaf7f4ae15ea9569571db6672ab/src/test/java/org/jvnet/hudson/test/JenkinsRuleNonLocalhost.java |
Author
|
That's true if you bind JenkinsRule instance to 0.0.0.0. Then its possible to access it from remote depends on the network setup. I could add a log warning too. The default is still localhost and has to be conciously overwritten with a different IP or hostname. |
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this change is that the JenkinRule based tests were all running
inside a docker container and i needed a way to bind it a non localhost address
in order to access it from outside the running container.
The host binding for the JenkinsRule is configurable with the
hostproperty. The default value is
localhostthis keeps the backwardcompatibility.
The following code snippet shows how to bind the JenkinsRule instance
to all network interfaces. This is similar to set the
hostvalue to0.0.0.0.The test case
JenkinsRuleHostIPTestvalidates that the assignment to a specifichost ip address is working correctly.
The test case
JenkinsRuleAllHostInterfaceTestvalidates that the assignment to allnetwork interfaces is working correctly.