Ensure JenkinsRule#after() is called even when timeout is reached
#264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
reviewed
Mar 2, 2021
Member
jglick
left a comment
jglick
left a comment
There was a problem hiding this comment.
Maybe right? But could also perhaps regress something. I wonder if JenkinsSessionRule behaves more nicely?
Member
|
At least merge with |
Member
But that may be a good thing, since shutdown invokes user code and thus could hang, right? |
Vlatombe
changed the title
JenkinsRule#after() is called even when timeout is reached
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see from time to time some tests from
kubernetes-plugintiming out. When that happens, subsequent tests fail because they try to allocate the same port. I've noticed that the timeout exception isn't handled the same way as a generic failure, in particular it doesn't runafter().