Skip to content

Warn when 'Check out to a sub-directory' is used with Pipeline jobs (fixes #3068) #3899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nimbusprogrammer wants to merge 3 commits into
base: master
Choose a base branch
from
+54 −0
Open

Warn when 'Check out to a sub-directory' is used with Pipeline jobs (fixes #3068) #3899

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ecf243
Warn when 'Check out to a sub-directory' is used with Pipeline jobs (…
Nimbusprogrammer Dec 7, 2025
73df5a6
test: verify warning when RelativeTargetDirectory used in Pipeline
Nimbusprogrammer Dec 7, 2025
1e249b7
tests: migrate to @WithGitSampleRepo and assert Pipeline warnings
Nimbusprogrammer Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/hudson/plugins/git/extensions/impl/RelativeTargetDirectory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@
if (relativeTargetDir == null || relativeTargetDir.length() == 0 || relativeTargetDir.equals(".")) {
return workspace;
}
//fixing issue : #3068 : Warn if used in Pipeline
if ( context != null && context.getClass().getName().equals("org.jenkinsci.plugins.workflow.job.WorkflowJob")){

Check warning on line 42 in src/main/java/hudson/plugins/git/extensions/impl/RelativeTargetDirectory.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Partially covered line 

Line 42 is only partially covered, 2 branches are missing
listener.getLogger().println("[Warning] 'Check out to a sub-directory' is not intended for use with Pipeline jobs. Please use the 'dir' step instead. ");

Check warning on line 43 in src/main/java/hudson/plugins/git/extensions/impl/RelativeTargetDirectory.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered line 

Line 43 is not covered by tests
}
return workspace.child(environment.expand(relativeTargetDir));
}

Expand Down
Loading