Skip to content

Conversation

@MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Dec 3, 2025

Add markewaite as maintainer of 3 plugins

I've included these changes in a single pull request because they can all be approved by @basil. If he doesn't approve them, I'm willing to wait the 2 weeks for the adoption request to be approved.

Add markewaite as a timestamper plugin maintainer

Pull request to be merged:

Current maintainers that can approve my addition:

Add markewaite as a maintainer of throttle-concurrent-builds plugin

Pull request to merge:

Current maintainers that can approve the addition:

Add markewaite as a text-finder plugin maintainer

Pull request to be merged:

Current maintainers that can approve the addition:

Link to GitHub repository

When modifying release permission

List the GitHub usernames of the users who should have commit permissions below:

  • @MarkEWaite

This is needed in order to cut releases of the plugin or component.

If you are modifying the release permission of your plugin or component, fill out the following checklist:

Release permission checklist (for submitters)

  • The usernames of the users added to the "developers" section in the .yml file are the same the users use to log in to accounts.jenkins.io.
  • All users added have logged in to Artifactory and Jira once.
  • I have mentioned an existing team member of the plugin or component team to approve this request.

When enabling automated releases (cd: true)

Follow the documentation to ensure, your pull request is set up properly. Don't merge it yet.
In case of changes requested by the hosting team, an open PR facilitates future reviews, without derailing work across multiple PRs.

Link to the PR enabling CD in your plugin

CD checklist (for submitters)

  • I have provided a link to the pull request in my plugin, which enables CD according to the documentation.

Reviewer checklist

  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it.

Pull request to be merged:

* jenkinsci/text-finder-plugin#295

Current maintainers that can approve the addition:

* @basil
* @jglick
Pull request to be merged:

* jenkinsci/timestamper-plugin#394

Current maintainers that can approve my addition:

* @basil
* @StevenGBrown
Pull request to be merged:

* jenkinsci/ws-cleanup-plugin#267

Current maintainers that can approve my addition as a maintainer:

* @basil
* @vjuranek
* @PaJaSoft
@MarkEWaite MarkEWaite requested a review from a team as a code owner December 3, 2025 12:11
@oleg-nenashev
Copy link
Contributor

Approved

@jglick
Copy link
Contributor

jglick commented Dec 3, 2025

I am not even sure what the text-finder plugin is, or why I might have been marked as a maintainer.

@MarkEWaite
Copy link
Contributor Author

I am not even sure what the text-finder plugin is, or why I might have been marked as a maintainer.

You became a maintainer of that plugin in 2016 with commit a673619 , the initial upload of permissions.

@MarkEWaite MarkEWaite changed the title Add markwaite as maintainer of 4 plugins Add markewaite as maintainer of 4 plugins Dec 3, 2025
@jglick
Copy link
Contributor

jglick commented Dec 3, 2025

jenkinsci/text-finder-plugin#12 (comment) and seven years after that I certainly have no idea. Consider it abandoned, whatever it is.

@MarkEWaite MarkEWaite changed the title Add markewaite as maintainer of 4 plugins Add markewaite as maintainer of 3 plugins Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants