Open
Conversation
… client. Upgraded to java 8
Cleaned up jelastic maven plugin
Collaborator
|
Hello, Iulian I'm done code review of your changes. Please see summary below: The following functionality is missing
The following functionality doesn't work properly
We would also suggest to fix the following:
|
* Allow user to pass friendly name for node group This commit allows the user to pass in the friendly name for the node group (which is displayed in the Jelastic UI) instead of the name, which can only be fetched via the API. If an invalid node group is passed (that is, the value passed doesn't match any node group name or friendly name), then the plugin will error out. * add new display name property * Support both nodeGroup and nodeGroupName This commit: - add supports for nodeGroup and nodeGroupName. The value of nodeGroup has priority on nodeGroupName and will not be validated. - add error handling to the validation logic of the nodeGroupName. - updates the Jelastic API library to the latest version * upgrade version Co-authored-by: Iulian <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did a major cleanup of the plugin and added support for sequential deployment with delay when the server has multiple nodes, among other improvements.
Feel free to review, QA and merge if you want to.