Skip to content

fix(gomod_tidy): comment out broken check#696

Open
matdibu wants to merge 1 commit intojdx:mainfrom
matdibu:gomod_tidy
Open

fix(gomod_tidy): comment out broken check#696
matdibu wants to merge 1 commit intojdx:mainfrom
matdibu:gomod_tidy

Conversation

@matdibu
Copy link
Contributor

@matdibu matdibu commented Feb 16, 2026

check_diff should work once #640 is merged

until then, running the check results in

hk WARN  failed to canonicalize file: current/go.sum No such file or directory (os error 2)
hk WARN  failed to canonicalize file: tidy/go.sum No such file or directory (os error 2)

@gemini-code-assist
Copy link

Summary of Changes

Hello @matdibu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a temporary workaround to prevent a known issue with the go mod tidy -diff check from causing build failures. By disabling this specific check, the PR ensures that the continuous integration process remains stable while awaiting a more permanent solution in a separate, upcoming change.

Highlights

  • Temporary Check Disablement: The check_diff command for go mod tidy has been commented out in pkl/builtins/gomod_tidy.pkl to prevent build failures until a related issue (feat: Parse Go-style diffs #640) is resolved.
Changelog
  • pkl/builtins/gomod_tidy.pkl
    • Commented out the check_diff command for go mod tidy.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request temporarily disables the check_diff functionality for gomod_tidy by commenting it out, which is a reasonable workaround for the issue described. My review includes a suggestion to improve the comment style for better long-term maintainability, using a standard TODO format to ensure the temporary change is tracked and reverted once the blocking issue is resolved.

gomod_tidy = new Config.Step {
glob = "**/go.mod"
check_diff = "go mod tidy -diff"
// check_diff = "go mod tidy -diff" // won't work until #640 is merged

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better tracking and future maintainability, it's a good practice to use a TODO comment format that includes the issue or PR number, and to place it on its own line for clarity. This makes it easier for developers and automated tools to find and address temporary workarounds later.

  // TODO(#640): Re-enable `check_diff` once the underlying issue is fixed.
  // check_diff = "go mod tidy -diff"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments