-
Notifications
You must be signed in to change notification settings - Fork 210
pci: add parent device address #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,11 +21,13 @@ import ( | |
|
|
||
| type Device struct { | ||
| // The PCI address of the device | ||
| Address string `json:"address"` | ||
| Vendor *pcidb.Vendor `json:"vendor"` | ||
| Product *pcidb.Product `json:"product"` | ||
| Revision string `json:"revision"` | ||
| Subsystem *pcidb.Product `json:"subsystem"` | ||
| Address string `json:"address"` | ||
| // The PCI address of the parent device | ||
| ParentAddress string `json:"parent_address"` | ||
| Vendor *pcidb.Vendor `json:"vendor"` | ||
| Product *pcidb.Product `json:"product"` | ||
| Revision string `json:"revision"` | ||
| Subsystem *pcidb.Product `json:"subsystem"` | ||
| // optional subvendor/sub-device information | ||
| Class *pcidb.Class `json:"class"` | ||
| // optional sub-class for the device | ||
|
|
@@ -47,15 +49,17 @@ type devIdent struct { | |
| } | ||
|
|
||
| type devMarshallable struct { | ||
| Driver string `json:"driver"` | ||
| Address string `json:"address"` | ||
| Vendor devIdent `json:"vendor"` | ||
| Product devIdent `json:"product"` | ||
| Revision string `json:"revision"` | ||
| Subsystem devIdent `json:"subsystem"` | ||
| Class devIdent `json:"class"` | ||
| Subclass devIdent `json:"subclass"` | ||
| Interface devIdent `json:"programming_interface"` | ||
| Driver string `json:"driver"` | ||
| Address string `json:"address"` | ||
| ParentAddress string `json:"parent_address"` | ||
| Vendor devIdent `json:"vendor"` | ||
| Product devIdent `json:"product"` | ||
| Revision string `json:"revision"` | ||
| Subsystem devIdent `json:"subsystem"` | ||
| Class devIdent `json:"class"` | ||
| Subclass devIdent `json:"subclass"` | ||
| Interface devIdent `json:"programming_interface"` | ||
| IOMMUGroup string `json:"iommu_group"` | ||
| } | ||
|
|
||
| // NOTE(jaypipes) Device has a custom JSON marshaller because we don't want | ||
|
|
@@ -64,8 +68,9 @@ type devMarshallable struct { | |
| // human-readable name of the vendor, product, class, etc. | ||
| func (d *Device) MarshalJSON() ([]byte, error) { | ||
| dm := devMarshallable{ | ||
| Driver: d.Driver, | ||
| Address: d.Address, | ||
| Driver: d.Driver, | ||
| Address: d.Address, | ||
| ParentAddress: d.ParentAddress, | ||
| Vendor: devIdent{ | ||
| ID: d.Vendor.ID, | ||
| Name: d.Vendor.Name, | ||
|
|
@@ -91,6 +96,7 @@ func (d *Device) MarshalJSON() ([]byte, error) { | |
| ID: d.ProgrammingInterface.ID, | ||
| Name: d.ProgrammingInterface.Name, | ||
| }, | ||
| IOMMUGroup: d.IOMMUGroup, | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I forgot add this in #430 so I am trying to sneakily add it here
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I moved this into a separate commit |
||
| } | ||
| return json.Marshal(dm) | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm contemplating if we should add this at the end of the struct for abundant (excessive?) backward compatibility concerns. But OTOH we mostly (99%) serialize back/from YAML/JSON and clients just recompile, so it's probably OK