Optimize "uniq" to be O(n) instead of O(n^2)#2537
Open
Tzook wants to merge 2 commits intojashkenas:masterfrom
Tzook:master
Open
Optimize "uniq" to be O(n) instead of O(n^2)#2537Tzook wants to merge 2 commits intojashkenas:masterfrom Tzook:master
Tzook wants to merge 2 commits intojashkenas:masterfrom
Tzook:master
Conversation
Contributor
|
Keep in mind this toggles the matching behavior from strict equality to same value zero depending on environment support. |
Author
|
Good point @jdalton. |
Contributor
|
Yep. |
|
Hello everyone, Thanks |
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The uniq function does heavy operations that could cause performance issues on big arrays.
This commit utilizes the Map object if supported (95% browser support according to caniuse), to make such cases much faster.
Running a simple example in Chrome on an array with 10,000 unique elements: