Skip to content

Alias mapObject to mapValues#2073

Open
jridgewell wants to merge 1 commit intojashkenas:masterfrom
jridgewell:mapObject-mapValues
Open

Alias mapObject to mapValues#2073
jridgewell wants to merge 1 commit intojashkenas:masterfrom
jridgewell:mapObject-mapValues

Conversation

@jridgewell
Copy link
Collaborator

For the record, I like _.mapObject better. But this change was undiscussed.

Re: #2061, 4f771e0

@jamiebuilds
Copy link
Contributor

_.mapValues makes more sense to me as you are only manipulating the values in the object and not the keys. _.mapObject implies a limited set of functionality that _.transform has.

@paulfalgout
Copy link
Contributor

👍

@captbaritone
Copy link
Collaborator

I like the alias, but the PR should also update tests.

For the record, I like `_.mapObject` better. But this change was
undiscussed.

Re: jashkenas#2061, 4f771e0
@jridgewell
Copy link
Collaborator Author

@captbaritone: You got it. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants