Merged
Conversation
Contributor
|
Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Issue : #3
It's not an open issue but as I was reading the comments you seems interested in this changes.
❓ Type of change
📚 Description
Resolves : #3
Context
Currently, requests that receive 500+ status codes throw an error instead of returning an ApiResponse object.
This makes it difficult to test and handle server errors in a consistent way.
Changes
Benefits
Breaking Changes
📝 Checklist
I am ready to open a PR on the doc if this one is merged.
It's my first "real"' open-source PR, feel free to point out any mistakes or improvements I can make to it 😄