fix: add -v/--verbose to explore, record, generate, cascade#719
Open
Astro-Han wants to merge 1 commit intojackwener:mainfrom
Open
fix: add -v/--verbose to explore, record, generate, cascade#719Astro-Han wants to merge 1 commit intojackwener:mainfrom
Astro-Han wants to merge 1 commit intojackwener:mainfrom
Conversation
Built-in browser commands were registered directly in cli.ts and missed the -v/--verbose flag that commanderAdapter.ts wires up for adapter commands. Also switch explore's lone log.debug() call to log.verbose() so the flag has visible effect. Closes jackwener#716
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Built-in browser commands (
explore,record,generate,cascade) are registered directly incli.tsand missed the-v/--verboseflag thatcommanderAdapter.tswires up for adapter commands. This PR adds the flag to all four commands using the sameprocess.env.OPENCLI_VERBOSE = '1'pattern.Also switches the lone
log.debug()inexplore.tstolog.verbose()so the flag has visible effect.Related issue: #716
Type of Change
Checklist