refactor: remove unused newTab() and closeTab() from IPage#709
Merged
refactor: remove unused newTab() and closeTab() from IPage#709
Conversation
Both methods had zero production callers — only test mocks referenced them. newTab() created about:blank pages via CDP Target.createTarget, but no adapter or pipeline step ever invoked it. closeTab() was similarly unused. selectTab() and tabs() are kept as they have active production usage (e.g. doubao adapter). The scoreTarget about:blank penalty is retained as a defensive measure against user-opened blank tabs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
newTab()andcloseTab()from theIPageinterface,BasePageabstract class, and both implementations (Page,CDPPage)What's kept
selectTab()andtabs()— have active production usage (e.g. doubao adapter)scoreTargetabout:blank penalty — defensive measure against user-opened blank tabsop: 'new'handler — keeps extension API completeVerification
tsc --noEmitpassesTest plan
npx tsc --noEmitpassesnewTab()orcloseTab()selectTab()andtabs()still have production callers