Skip to content

update the Gradle build tool to v8.14.4#2641

Merged
yaRnMcDonuts merged 1 commit intomasterfrom
sgold/gradle8144
Mar 11, 2026
Merged

update the Gradle build tool to v8.14.4#2641
yaRnMcDonuts merged 1 commit intomasterfrom
sgold/gradle8144

Conversation

@stephengold
Copy link
Member

Currently Gradle v8.8 is specified, which supports building on (and with) Java 1.8 through 22.

This change causes Gradle v8.14.4 to be used instead. This should allow the Engine to be built on (and with) Java 23 and 24.

In order to support Java 25+ build environments, we'd need to upgrade to Gradle v9, but unfortunately the latest production release of JMonkeyEngine SDK (3.8.0) is based on NetBeans 25, which doesn't work right with Gradle v9. Also, the current build scripts are incompatible with Gradle v9 because they use some deprecated Gradle features (such as auto-loading test framework implementation dependencies).

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's Gradle build tool to version 8.14.4. This essential upgrade ensures compatibility with newer Java environments, specifically Java 23 and 24, allowing the project to leverage the latest language features and improvements. The change was carefully implemented to avoid breaking compatibility with the current JMonkeyEngine SDK and existing build scripts, which are not yet ready for Gradle v9.

Highlights

  • Gradle Version Update: The Gradle build tool has been updated from version 8.8 to 8.14.4.
  • Java Version Support: This update enables building the Engine with Java versions 23 and 24.
  • Compatibility Considerations: An upgrade to Gradle v9 was avoided due to incompatibility with JMonkeyEngine SDK 3.8.0 (NetBeans 25) and existing build scripts using deprecated Gradle features.
Changelog
  • gradle/wrapper/gradle-wrapper.properties
  • gradlew
    • Added SPDX-License-Identifier: Apache-2.0.
    • Modified the APP_HOME calculation to use printf '%s\n' "$PWD" for current directory.
    • Changed CLASSPATH initialization to an empty string.
    • Updated the Gradle execution command to use -jar with gradle-wrapper.jar instead of -classpath with org.gradle.wrapper.GradleWrapperMain.
  • gradlew.bat
    • Added SPDX-License-Identifier: Apache-2.0.
    • Cleared the CLASSPATH variable.
    • Updated the Gradle execution command to use -jar with gradle-wrapper.jar.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Gradle build tool from version 8.8 to 8.14.4. The changes include updating the distributionUrl in gradle/wrapper/gradle-wrapper.properties and modifying the gradlew and gradlew.bat scripts. These script changes are standard for a Gradle wrapper update, such as switching to using the -jar option for launching Gradle. The changes are correct and align with the stated goal of the pull request.

@stephengold
Copy link
Member Author

I believe this is ready to be integrated into the "master" branch.

@yaRnMcDonuts if you would like me to perform the merge, let me know.

@yaRnMcDonuts yaRnMcDonuts merged commit 9f087c0 into master Mar 11, 2026
17 checks passed
@stephengold stephengold deleted the sgold/gradle8144 branch March 11, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants