update the Gradle build tool to v8.14.4#2641
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's Gradle build tool to version 8.14.4. This essential upgrade ensures compatibility with newer Java environments, specifically Java 23 and 24, allowing the project to leverage the latest language features and improvements. The change was carefully implemented to avoid breaking compatibility with the current JMonkeyEngine SDK and existing build scripts, which are not yet ready for Gradle v9. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Gradle build tool from version 8.8 to 8.14.4. The changes include updating the distributionUrl in gradle/wrapper/gradle-wrapper.properties and modifying the gradlew and gradlew.bat scripts. These script changes are standard for a Gradle wrapper update, such as switching to using the -jar option for launching Gradle. The changes are correct and align with the stated goal of the pull request.
|
I believe this is ready to be integrated into the "master" branch. @yaRnMcDonuts if you would like me to perform the merge, let me know. |
Currently Gradle v8.8 is specified, which supports building on (and with) Java 1.8 through 22.
This change causes Gradle v8.14.4 to be used instead. This should allow the Engine to be built on (and with) Java 23 and 24.
In order to support Java 25+ build environments, we'd need to upgrade to Gradle v9, but unfortunately the latest production release of JMonkeyEngine SDK (3.8.0) is based on NetBeans 25, which doesn't work right with Gradle v9. Also, the current build scripts are incompatible with Gradle v9 because they use some deprecated Gradle features (such as auto-loading test framework implementation dependencies).