Skip to content

WIP/Fix: correct parallel projection frustum plane normals for left/right #2640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zzuegg wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

WIP/Fix: correct parallel projection frustum plane normals for left/right #2640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions jme3-core/src/main/java/com/jme3/renderer/Camera.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1344,10 +1344,14 @@ public void onFrustumChange() {
coeffTop[0] = -frustumNear * inverseLength;
coeffTop[1] = frustumTop * inverseLength;
} else {
coeffLeft[0] = 1;
// getLeft() returns up×direction, but the view matrix (fromFrame)
// uses direction×up = -getLeft() as its X axis. Negate the left/right
// coefficients so the frustum plane normals match the view matrix,
// giving correct culling for any camera orientation.
coeffLeft[0] = -1;
coeffLeft[1] = 0;

coeffRight[0] = -1;
coeffRight[0] = 1;
coeffRight[1] = 0;

coeffBottom[0] = 1;
Expand Down
Loading