Replaced Android support-v4 library with AndroidX loader library#132
Replaced Android support-v4 library with AndroidX loader library#132leandroruiz96 wants to merge 2 commits intoj256:mainfrom
Conversation
|
Leaving this on draft because this will need to setup the Android SDK on the CCI pipeline. |
|
We need this fix too! |
|
What does this do to the backwards compatibility? @kpgalligan any comments? |
|
Should I release 2 versions? One with the old android-support and one with AndroidX? |
|
That would be helpful for the people who still haven't migrated to AndroidX. But considering that the original Android support library is no longer maintained, I wouldn't keep the support version for much longer. |
|
Hi @j256, do you have any update on this? |
…brary - Now builds .aar - Added .aar plugins for maven - Needs Android SDK (just set $ANDROID_HOME environment variable)
|
Hi @j256! every conflict has been resolved for this pull request. Could you take a look at this update for a future merging? Thanks in advance! |
|
Hey @leandroruiz96 , can you merge up from trunk. I see a lot of duplicate changes were are confusing the diff. |
1ee3a61 to
87c31c7
Compare
|
Hey @j256, I've merged up the changes again. So, you will be able to see just the changes related to this merge request. |
|
How can I test these changes? I'm not up on my Android testing. I'd like to verify that the old version of the generated files work as well as the new. |
|
To test this, you will need to package the library and import the ormlite-android.aar generated into an android project. The easiest way to do this is by placing the aar into a libs folder inside the main module in your Android project: and adding it in the build.gradle as a dependency:
|
|
Hi @j256, just to check. Could you test the changes? It'll be really nice to have this merged in a future release. |
|
Hi, this would help us a lot as well 👍 |
|
Hi @j256, I hope you are doing well. Have you had the chance to review this branch? It'd be very helpful to have it merged. |
|
I would like to turn off Jetifier, but this library is holding that up. Would be great if this can be merged this in :) |
|
+1 |
|
Hi @j256 , I really hope you are doing well. Have you had the chance to review this change?. We need to remove jetifier from our application and this change is a must. Thanks, |

Replaced deprecated Android support-v4 library with AndroidX loader library