Skip to content

Fix fetch error status #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nleush merged 3 commits into from
Mar 13, 2026
Merged

Fix fetch error status #634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16e6b5a
find places where `error` not passed to `registerFetchError`
nleush Mar 13, 2026
cd65e89
fix wrong fetch errors registering
nleush Mar 13, 2026
f0963ad
remove todo
nleush Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1503,7 +1503,7 @@
var fetch_data = {...data};

if (!data.error && !data.status_code) {
console.warn('No error param in registerFetchError data');
console.warn('No error param in registerFetchError data', data);
} else if (data.error) {
// Convert runtime `error` to `error_code` and `error_message`.
if (typeof data.error === 'string') {
Expand Down
8 changes: 6 additions & 2 deletions lib/plugins/system/meta/cachedMeta.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,9 @@ export default {
}
}

if (data.error.responseStatusCode !== 200) {
// Redirects don't have `responseStatusCode`. Only errors have status.
if (data.error.responseStatusCode
&& data.error.responseStatusCode !== 200) {
options.registerFetchError({
source: 'cache',
url: url,
Expand All @@ -96,7 +98,9 @@ export default {
cb(data.error);
} else if (data.htmlparser) {

if (data.htmlparser.__statusCode !== 200) {
// Wrong content types don't have `__statusCode`. Only errors have status.
if (data.htmlparser.__statusCode
&& data.htmlparser.__statusCode !== 200) {
options.registerFetchError({
source: 'cache',
url: url,
Expand Down
Loading