Merged
Conversation
The current code compares quoted URLs, i.e. `quoted_url.endswith(quote(document_type))`. However, URL encoding is case-insensitive, so this fails if the SMP escapes characters in their URL with e.g. %3a, but Python `quote` quotes with %3A. This PR flips the check by comparing `unquote(quoted_url).endswith(document_type)` which should remove any inconsistencies on quoting.
Collaborator
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code compares quoted URLs, i.e.
quoted_url.endswith(quote(document_type)). However, URL encoding is case-insensitive, so this fails if the SMP escapes characters in their URL with e.g. %3a, but Pythonquotequotes with %3A. This PR flips the check by comparingunquote(quoted_url).endswith(document_type)which should remove any inconsistencies on quoting.Sorry, this will cause a one-line conflict with #21, but I wanted to keep the changes understandable and clean. Can also resolve it myself.