fix: update to fix minor and low priority issues#14
Merged
privateip merged 1 commit intoitential:mainfrom Mar 9, 2026
Merged
Conversation
Contributor
privateip
commented
Mar 9, 2026
privateip
commented
- Add return types and parameter annotations to Client.init, aenter, aexit, and ServiceBase.init to fulfil the Typing :: Typed classifier
- Pin ipsdk to >=0.3.0 to prevent silent breakage from upstream changes
- Declare PyYAML as an optional dependency under the [yaml] extra so it is explicitly installable rather than requiring a manual uv add
- Replace sys.exit(1) with raise SystemExit(1) in fatal() so the library never forcibly terminates the calling process
- Replace bare print() calls in main.py with sys.stdout.write() ahead of any future CLI work
- Update TestFatalFunction tests to assert SystemExit is raised and verify the exit code rather than mocking sys.exit
- Add return types and parameter annotations to Client.__init__, __aenter__, __aexit__, and ServiceBase.__init__ to fulfil the Typing :: Typed classifier - Pin ipsdk to >=0.3.0 to prevent silent breakage from upstream changes - Declare PyYAML as an optional dependency under the [yaml] extra so it is explicitly installable rather than requiring a manual uv add - Replace sys.exit(1) with raise SystemExit(1) in fatal() so the library never forcibly terminates the calling process - Replace bare print() calls in __main__.py with sys.stdout.write() ahead of any future CLI work - Update TestFatalFunction tests to assert SystemExit is raised and verify the exit code rather than mocking sys.exit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.