Skip to content

Added the ability to run the code by pressing CMD/Ctrl+Enter #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
egfanboy wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added the ability to run the code by pressing CMD/Ctrl+Enter #23

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57fe595
Added the ability to run the code by pressing CMD/Ctrl+Enter
egfanboy Oct 5, 2019
858f7f0
Bind to editor
egfanboy Oct 5, 2019
a7b694d
PR comments
egfanboy Oct 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion client/components/submitProgram.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import CodeEditorComp from './codeEditor';
import { addEvent, dispatchEvent } from '../utilities/eventBus';

//Define Variables
let submitProgramElem, language, input, sourceCode;
let submitProgramElem, language, input, sourceCode, editorElement;

//Public Methods

Expand Down Expand Up @@ -52,13 +52,31 @@ async function _onClick(event) {
dispatchEvent('submitProgram:output', output);
}

let MacCMDPressed = false;

const MacCommandKeys = ['MetaLeft', 'MetaRight'];

function _onKeyDown(event) {
if ((event.ctrlKey || MacCMDPressed) && event.keyCode === 13) {
_onClick(event);
}

if (MacCommandKeys.includes(event.code)) {
MacCMDPressed = true;
} else {
MacCMDPressed = false;
}
}

//init
(() => {
//DOM binding
submitProgramElem = document.getElementById('submitBtn');
editorElement = document.getElementById('editor');
Copy link
Owner

@itaditya itaditya Oct 6, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EricTurf in this project I'm using pub-sub design pattern to enable proper Separation of Concerns. Each component is responsible to deal with their own DOM. submitProgram component shouldn't querySelect the codeEditor component.

The components interact with each other by dispatching events and subscribing to events.

What you have to do is in the codeEditor component, add the _keyDown event listener and the whole CMD + P logic. When you detect that it was indeed CMD + P you dispatch an event say codeEditor:runcode.
Then in the submitProgram component, listen to the codeEditor:runcode event using addEvent helper. When the codeEditor:runcode is triggered, you have to call the _onClick method.

Copy link
Owner

@itaditya itaditya Oct 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference see how submitProgram and langSel components interact with each other.


//Event Bindings
submitProgramElem.addEventListener('click', _onClick);
editorElement.addEventListener('keydown', _onKeyDown);
})();

//Expose Component
Expand Down
Loading