Skip to content

Small updates to applyRtc() #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gshiroma wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Small updates to applyRtc() #82

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d1c4d7f
disable polarimetric symmetrization by default
gshiroma Jul 3, 2025
0ef09a8
Merge branch 'isce-framework:develop' into develop
gshiroma Jul 9, 2025
2ac2694
revert changes to `symmetrize_cross_pol_channels`
gshiroma Jul 22, 2025
05d7fda
Update GCOV and GSLC specification XMLs
gshiroma Jul 22, 2025
749058d
Revert changes to the GCOV and GSLC specification XMLs
gshiroma Jul 23, 2025
fc8ac53
Merge branch 'isce-framework:develop' into develop
gshiroma Jul 24, 2025
064d073
Merge branch 'isce-framework:develop' into develop
gshiroma Aug 7, 2025
967cdc3
consider valid the pixels with zero values
gshiroma Aug 7, 2025
775870e
pass `rtc_min_value` instead of `rtc_min_value_db` to `_applyRtc()`
gshiroma Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions cxx/isce3/geometry/RTC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,6 @@ void _clip_min_max(std::complex<T>& radar_value, float clip_min, float clip_max)
*/
using T_real = typename isce3::real<T>::type;

// no data (complex)
if (std::abs(radar_value) == 0) {
radar_value *= std::numeric_limits<T_real>::quiet_NaN();
return;
}

// clip min (complex)
if (!std::isnan(clip_min) && std::abs(radar_value) < clip_min)
// update magnitude without changing the phase
Expand Down Expand Up @@ -375,20 +369,20 @@ void applyRtc(const isce3::product::RadarGridParameters& radar_grid,
if (input_raster.dtype() == GDT_Float32 ||
(input_raster.dtype() == GDT_CFloat32 && flag_complex_to_real))
_applyRtc<float>(input_raster, *rtc_raster, output_raster,
rtc_min_value_db, abs_cal_factor, clip_min, clip_max, info,
rtc_min_value, abs_cal_factor, clip_min, clip_max, info,
flag_complex_to_real);
else if (input_raster.dtype() == GDT_Float64 ||
(input_raster.dtype() == GDT_CFloat64 && flag_complex_to_real))
_applyRtc<double>(input_raster, *rtc_raster, output_raster,
rtc_min_value_db, abs_cal_factor, clip_min, clip_max, info,
rtc_min_value, abs_cal_factor, clip_min, clip_max, info,
flag_complex_to_real);
else if (input_raster.dtype() == GDT_CFloat32)
_applyRtc<std::complex<float>>(input_raster, *rtc_raster, output_raster,
rtc_min_value_db, abs_cal_factor, clip_min, clip_max, info,
rtc_min_value, abs_cal_factor, clip_min, clip_max, info,
flag_complex_to_real);
else if (input_raster.dtype() == GDT_CFloat64)
_applyRtc<std::complex<double>>(input_raster, *rtc_raster,
output_raster, rtc_min_value_db, abs_cal_factor, clip_min,
output_raster, rtc_min_value, abs_cal_factor, clip_min,
clip_max, info, flag_complex_to_real);
else {
std::string error_message =
Expand Down
Loading