Add configurable handling for RTC minimum value thresholding (WIP)#197
Open
gshiroma wants to merge 24 commits intoisce-framework:developfrom
Open
Add configurable handling for RTC minimum value thresholding (WIP)#197gshiroma wants to merge 24 commits intoisce-framework:developfrom
gshiroma wants to merge 24 commits intoisce-framework:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds configurable options for handling RTC minimum value thresholding during RTC correction, as an alternative to PR #48. The new modes provide greater control over how samples with low RTC area factors are treated. Very low RTC area factors can lead to extremely large gains, approaching infinity when the RTC area factor is zero. This case is currently handled by marking the corresponding backscatter values as invalid (NaN).
This PR introduces five RTC minimum value handling modes, configurable through the GCOV runconfig:
DISABLED: No minimum-value thresholding is applied.CLIP: RTC values below the minimum threshold are clipped to the minimum value.INVALID: Samples with RTC values below the threshold are marked as invalid.BYPASS_RTC: RTC correction is bypassed for samples below the threshold.TRANSITION: RTC correction is bypassed with a smooth transition betweenrtc_transition_value_dbandrtc_min_value_db.In addition, this PR adds support for a configurable transition start value
(
rtc_transition_value_db) when using theTRANSITIONmode.