Add target_T_world parameter to IsaacTeleopDevice.advance() for frame#5042
Draft
rwiltz wants to merge 2 commits intoisaac-sim:developfrom
Draft
Add target_T_world parameter to IsaacTeleopDevice.advance() for frame#5042rwiltz wants to merge 2 commits intoisaac-sim:developfrom
rwiltz wants to merge 2 commits intoisaac-sim:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an optional target_T_world parameter to IsaacTeleopDevice.advance() that left-multiplies the world-to-anchor matrix before it enters the retargeting pipeline, allowing applications to receive all teleop poses in an arbitrary target frame (e.g. robot base link for IK controllers).
Support np.ndarray, torch.Tensor, and wp.array (via duck-typed .numpy()) as input types for the transform matrix.
Add unit tests for the _to_numpy_4x4 conversion helper and the rebase matrix multiplication logic.
Fixes # (issue)
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there