[water] Require IndexExprsSpecified normal form for LowerWaveToMLIR #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftynse
approved these changes
Jan 8, 2026
Contributor
ftynse
left a comment
ftynse
left a comment
There was a problem hiding this comment.
Maybe we should consider an alias form that regroups everything we need for lowering
tgymnich
approved these changes
Jan 9, 2026
tyb0807
force-pushed
the
idx_norm_form
branch
10 times, most recently
from
5e5b642 to
40485fe
Compare
Add IndexExprsSpecified to the preconditions for LowerWaveToMLIR pass. This ensures all memory operations have index expressions before lowering, removing the need for runtime checks in the lowering patterns. The IndexExprsSpecified verification is relaxed for vector-only ops (those without WaveTensorType operands/results), since after elements-per-thread propagation these ops no longer need index expressions. ReadOp and WriteOp are always checked as they perform memory accesses regardless of type. Signed-off-by: tyb0807 <[email protected]>
tyb0807
force-pushed
the
idx_norm_form
branch
from
40485fe to
ea03d73
Compare
Contributor
Author
|
I needed to relax the IndexExprsSpecified verification for vector-only ops (those without WaveTensorType operands/results), since after |
ftynse
reviewed
Jan 12, 2026
Signed-off-by: tyb0807 <[email protected]>
ftynse
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add IndexExprsSpecified to the preconditions for LowerWaveToMLIR pass. This ensures all memory operations have index expressions before lowering, removing the need for runtime checks in the lowering patterns.