feat(angular): update to Angular 20 #1828
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| public user: UserService, | ||
| public config: Config | ||
| ) { | ||
| constructor() { |
There was a problem hiding this comment.
We should be using ngOnInit so we can completely move away from constructor (since Angular prefers inject) but it throws a warning regarding the icons not loading in. We should look into this more since the icons did load fine so the warning is being thrown too soon.
There was a problem hiding this comment.
We can move most things to ngOnInit I believe, but not icon registration. There's no Angular lifecycle hook that renders soon enough for the template to know that the icons exist, so I'll keep icon registration in constructors, unfortunately.
It may be worth looking into ionicons to see if we can defer that check, but probably not as part of this upgrade.
…ndencies in the package-lock, and fixing tests
…destroy, making image in support align with other ionic images to prevent it from complaining about its resolution, updating typescript to be a bit more modern
| width="200" | ||
| height="200" | ||
| priority | ||
| /> |
There was a problem hiding this comment.
This image styling was conflicting with its CSS and causing a ratio conflict. In this change, I tried to make it act like the Ionic logos in its neighboring pages.
Issue URL: internal
What is the current behavior?
The app runs on Angular 19.
What is the new behavior?
Does this introduce a breaking change?
Other information
N/A