Open
Conversation
src/main/kotlin/io/ionic/libs/iongeolocationlib/controller/IONGLOCSensorHandler.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/iongeolocationlib/controller/IONGLOCController.kt
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/iongeolocationlib/controller/IONGLOCController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/iongeolocationlib/controller/IONGLOCSensorHandler.kt
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/iongeolocationlib/controller/IONGLOCController.kt
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/iongeolocationlib/controller/IONGLOCSensorHandler.kt
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/iongeolocationlib/controller/helper/IONGLOCExtensions.kt
Show resolved
Hide resolved
src/main/kotlin/io/ionic/libs/iongeolocationlib/controller/IONGLOCSensorHandler.kt
Show resolved
Hide resolved
src/test/java/io/ionic/libs/iongeolocationlib/controller/IONGLOCControllerTest.kt
Show resolved
Hide resolved
OS-pedrogustavobilro
changed the title
addWatch
Contributor
OS-pedrogustavobilro
left a comment
OS-pedrogustavobilro
left a comment
There was a problem hiding this comment.
A few more comments, also I don't think you addressed / replied to all the above ones (I resolved the ones that are done)
src/main/kotlin/io/ionic/libs/iongeolocationlib/controller/IONGLOCSensorHandler.kt
Outdated
Show resolved
Hide resolved
src/test/java/io/ionic/libs/iongeolocationlib/controller/IONGLOCSensorHandlerTest.kt
Outdated
Show resolved
Hide resolved
| @@ -336,6 +335,9 @@ class IONGLOCController internal constructor( | |||
| private fun clearWatch(id: String, addToBlackList: Boolean): Boolean { | |||
| watchChannels.remove(id)?.close() | |||
Contributor
There was a problem hiding this comment.
Do we need the watchChannels variable now that you made the change at 4d49acc?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for
heading,magneticHeading,trueHeading,headingAccuracy, andcourseContext
https://outsystemsrd.atlassian.net/browse/RMET-4897
Type of changes
Tests
Tested on Pixel 8 Pro with Capacitor example app, ODC sample app, and O11 sample app