fix(cli): Don't overwrite config.server section with --live-reload#7528
Merged
OS-pedrogustavobilro merged 6 commits intoionic-team:mainfrom Feb 26, 2026
Merged
fix(cli): Don't overwrite config.server section with --live-reload#7528OS-pedrogustavobilro merged 6 commits intoionic-team:mainfrom
--live-reload#7528OS-pedrogustavobilro merged 6 commits intoionic-team:mainfrom
Conversation
…editCapConfigForLiveReload` function
3 tasks
OS-pedrogustavobilro
changed the title
editCapConfigForLiveReload function--live-reload
OS-pedrogustavobilro
changed the title
--live-reload--live-reload
OS-pedrogustavobilro
approved these changes
Feb 23, 2026
jcesarmobile
requested changes
Feb 24, 2026
Member
jcesarmobile
left a comment
jcesarmobile
left a comment
There was a problem hiding this comment.
The change is in editExtConfigForLiveReload, which is unused, should be done in editCapConfigForLiveReload
Contributor
|
Oh you're right, my bad, I had tested changing manually instead of going to the fork. Good catch! |
jcesarmobile
approved these changes
Feb 26, 2026
tossaro
pushed a commit
to tossaro/capacitor
that referenced
this pull request
Feb 26, 2026
…onic-team#7528) Co-authored-by: Pedro Bilro <pedro.gustavo.bilro@outsystems.com> Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Edit by @OS-pedrogustavobilro] Fixes #8352. Partially addresses #8303 (this one requires additional PRs)