Rework audio codec with soundfile #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There are a few internal packages for audio decoding are deprecating in Python3.13. A simpler way to move forward is simply to use SoundFile - Our currently decoding return a 16 bit integer data which can lose precision, essentially with PCM24 being a common bit depth. Thus the new change retain precision for different PCM depth and then convert to f32 for maximum detail retained. - As for FFmpeg, directly read into f32 is the easiest to handle mp3.
- We need to rethink whether we would like to support jupyter backend moving forward. This seems a lot of effort, but not a lot of actual use case - The current test is failing due to WS issue. I don't know why yet and doesn't have the time to dive deep into it yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.