-
Notifications
You must be signed in to change notification settings - Fork 822
[SYCL][PostLink] Fix Coverity issues in SYCLPostLink.cpp #21573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sarnex
merged 19 commits into
intel:sycl
from
hchilama:fix/sycl-postlink-coverity-issues
Mar 30, 2026
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
00efe0b
[Driver][sycl]Adding C++ libraries to the linker with -fsycl
hchilama dd92ec0
Adding the test file
hchilama 5e54742
Merge branch 'intel:sycl' into sycl
hchilama 0d84548
Merge branch 'intel:sycl' into sycl
hchilama 0123f76
Merge branch 'intel:sycl' into sycl
hchilama 7086c39
Merge branch 'intel:sycl' into sycl
hchilama 5faaeea
Merge branch 'intel:sycl' into sycl
hchilama 8ed9bdc
Merge branch 'intel:sycl' into sycl
hchilama 6cdda83
Merge branch 'intel:sycl' into sycl
hchilama 314c334
Merge branch 'intel:sycl' into sycl
hchilama 3a8ebea
Merge branch 'intel:sycl' into sycl
hchilama a1fd790
Merge branch 'intel:sycl' into sycl
hchilama e0704d5
Merge branch 'intel:sycl' into sycl
hchilama 81c51a6
Merge branch 'intel:sycl' into sycl
hchilama 6c2b310
Merge branch 'intel:sycl' into sycl
hchilama 137b25f
Merge branch 'intel:sycl' into sycl
hchilama 0afc179
[SYCL][PostLink] Fix Coverity issues in SYCLPostLink.cpp
hchilama d6ef8ce
worked on the review comments.
hchilama dfe532a
typo correction
hchilama File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can agree.
release()function just returns the pointer so that a caller is responsible to destroy the resource which is obviously not happen here. The best solution would be to do:This way unique_ptr would destroy the object.
In overall, this is done this way because IRs are fat and we want to release used RAM as soon as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought deleting the object when the pointer goes out of scope would be the safest if there is any early returns. But sure I can make sure the pointer to release sooner with
reset().There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was just a little optimization of RAM usage because our RAM usage is a known pain point.