Open
Conversation
cmake/Modules/DPCPPVersion.cmake should be updated to hold version information for each release.
Contributor
Author
|
CC: @tahonermann , @dvrogozh |
Contributor
dvrogozh
reviewed
Mar 19, 2026
YuriPlyakhin
approved these changes
Mar 19, 2026
Contributor
YuriPlyakhin
left a comment
YuriPlyakhin
left a comment
There was a problem hiding this comment.
llvm/CMakeLists.txt change LGTM
dvrogozh
reviewed
Mar 20, 2026
| Builder.defineMacro("__VERSION__", "\"" + | ||
| Twine(getClangFullCPPVersion()) + "\""); | ||
| // with GCC 4.2.1. Now, just return the full DPC++ version | ||
| Builder.defineMacro("__VERSION__", |
There was a problem hiding this comment.
@tahonermann , how about __VERSION__. Do we leave it with clang or update to dpcpp?
Contributor
There was a problem hiding this comment.
I think we update it to DPC++. That macro traditionally tracked GCC version, but Clang diverged from that some time ago. I don't think we need to be consistent with Clang for this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds DPC++ compiler self-identification macros to differentiate intel/llvm compiler from upstream Clang and enable version detection for intel/llvm releases.
Fixes:#21509
Depends on: #21570