[SYCL][GRAPH] Add empty method on graph#21554
Draft
lslusarczyk wants to merge 1 commit intointel:syclfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
empty()on modifiable command graphs so callers can test graph emptiness without relying onget_nodes().Motivation
We need to support both native Level Zero graphs and SYCL graphs behind a common usage pattern. Native L0 graph APIs expose something like
empty()but notget_nodes().PyTorch (and similar stacks) today often checks emptiness via
get_nodes(). That breaks when switching to native L0 graphs, whereget_nodes()is not available. Exposingempty()on the SYCL modifiable graph matches what native graphs can offer and gives PyTorch a single, portable way to ask “is this graph empty?” for both paths.Changes
modifiable_command_graph::empty()—truewhen the graph has no nodes.empty()documented insycl_ext_oneapi_graph.asciidoc(aligned withget_nodes/get_root_nodes).empty()inmodifiable_graph.hpp.CommandGraphTest::GraphEmptyinQueries.cpp(public API, consistency withget_nodes(), vsgraph_impl).Testing
CommandGraphExtensionTests— includes newGraphEmptycoverage.