tools/membw/Makefile: support EXTRA_CFLAGS and EXTRA_LDFLAGS #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add variables EXTRA_LDFLAGS and EXTRA_CFLAGS to compile, just like other directories in the project Signed-off-by: Hongxu Jia <[email protected]>
|
Hi Hongxu, |
There was a problem hiding this comment.
Pull request overview
This PR adds support for EXTRA_CFLAGS and EXTRA_LDFLAGS variables in the membw tool's Makefile, aligning it with the build conventions used in other directories of the project. This enhancement allows users to pass additional compiler and linker flags without modifying the Makefile directly.
- Added conditional inclusion of
EXTRA_CFLAGSto the compilation flags - Added conditional inclusion of
EXTRA_LDFLAGSto the linker flags
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add variables EXTRA_LDFLAGS and EXTRA_CFLAGS to compile, just like other directories in the project