refactor: migrate data_source_github_branch logging to tflog#3328
Closed
texasich wants to merge 1 commit intointegrations:mainfrom
Closed
refactor: migrate data_source_github_branch logging to tflog#3328texasich wants to merge 1 commit intointegrations:mainfrom
texasich wants to merge 1 commit intointegrations:mainfrom
Conversation
Replace the stdlib `log` package with `tflog` in data_source_github_branch.go, contributing to the broader migration tracked in integrations#3070. Structured key-value fields (org, repo, branch) are attached to the log entry alongside the formatted message, consistent with the pattern established in the other migrated files. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates
data_source_github_branch.gofrom the stdliblogpackage totflog, part of the work tracked in #3070.The one debug log statement (404 branch-not-found path) gets structured key-value fields attached alongside the formatted message, matching the pattern from the already-migrated files (
resource_github_membership.go,resource_github_actions_environment_secret.go).Changes:
"log"import for"fmt"+"github.com/hashicorp/terraform-plugin-log/tflog"log.Printf("[DEBUG] ...")?tflog.Debug(ctx, fmt.Sprintf(...), map[string]any{...})Tested: the function already uses
ReadContext, soctxis in scope. Import path verified against existing migrated files.