fix: respect proxy env vars in anonymous http client#3326
Open
dvcorreia wants to merge 1 commit intointegrations:mainfrom
Open
fix: respect proxy env vars in anonymous http client#3326dvcorreia wants to merge 1 commit intointegrations:mainfrom
dvcorreia wants to merge 1 commit intointegrations:mainfrom
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
|
/cc @stebje |
The anonymous HTTP client was using a bare `http.Transport{}`
which does not respect `HTTP_PROXY`/`HTTPS_PROXY` environment
variables. This change clones `http.DefaultTransport` instead,
which has `Proxy: http.ProxyFromEnvironment` set by default.
Related to integrations#1509
Signed-off-by: Diogo Correia <diogo.correia@siemens.com>
dvcorreia
force-pushed
the
fix/anonymous-client-proxy
branch
from
cd7faa3 to
6f071eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1509
Before the change?
http.Transport{}which does not respectHTTP_PROXY/HTTPS_PROXYenvironment variables.After the change?
http.DefaultTransportinstead, which hasProxy: http.ProxyFromEnvironmentset by default.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!