feat: Add custom_properties to github_repository and github_enterpris…#3322
Open
faradayfan wants to merge 1 commit intointegrations:mainfrom
Open
feat: Add custom_properties to github_repository and github_enterpris…#3322faradayfan wants to merge 1 commit intointegrations:mainfrom
faradayfan wants to merge 1 commit intointegrations:mainfrom
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
1 task
faradayfan
force-pushed
the
custom-properties
branch
from
5844ab3 to
9efa7f0
Compare
…e_custom_property resource (integrations#3230, integrations#3304) Allow custom properties to be set on repositories at creation time, fixing 422 errors when an organization enforces required custom properties. Adds a new github_enterprise_custom_property resource and data source for managing custom property definitions at the enterprise level. Uses context-aware CRUD functions, proper 404 handling, and ConfigStateChecks in acceptance tests per maintainer guidelines. Closes integrations#3230, integrations#3304
faradayfan
force-pushed
the
custom-properties
branch
from
9efa7f0 to
c96926f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Add custom_properties to github_repository and github_enterprise_custom_property resource
Allow custom properties to be set on repositories at creation time, fixing 422 errors when an organization enforces required custom properties. Also adds a new github_enterprise_custom_property resource and data source for managing custom property definitions at the enterprise level.
Resolves #3230, #3304
Before the change?
github_repositoryto return a 422 error on creation, since custom properties could only be set via a separategithub_repository_custom_propertyresource applied after creationAfter the change?
github_repositorynow accepts acustom_propertiesargument (a string map) that is included in the initial repository creation request, satisfying organization-required custom properties at creation timegithub_enterprise_custom_propertyresource allows managing custom property definitions at the enterprise level, mirroring the existinggithub_organization_custom_propertiesresourcegithub_enterprise_custom_propertydata source allows reading enterprise custom property definitionsgithub_repositorywith a new argument description and exampletestResourcePrefixnaming andConfigStateCheckspatternPull request checklist
Does this introduce a breaking change?