-
Notifications
You must be signed in to change notification settings - Fork 55
chore: update constraints-dev.txt (2025-06-09) #659
Conversation
|
looks like this fix should be applied here too: instructlab/eval@b8fedae |
|
Hmm - how am I still getting torch and nvidia libraries in here? Will need to debug that... |
|
As per the comment, These are dependencies that pull it. |
|
Right - it's just odd that these weren't in there before. But, I think the issue is originally I generated this file on a mac but now CI is generating it from a linux machine and that leads to substantially different set of packages included 😓 |
|
@bbrowning the script is supposed to explicitly ban anything but Linux: https://github.com/instructlab/ci-actions/blob/eabaa28dfec619e4dd2f0398055d6a5df32cc965/actions/update-constraints/generate_constraints.sh#L4-L7 |
|
@Mergifyio rebase |
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
✅ Branch has been successfully rebased |
e393fdf to
70d9fbc
Compare
|
@ktdreyer why is it complaining about DCO here? Haven't we disabled it? Or is it some setting on the org level that should be adjusted? |
booxter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks passed. DCO should be disabled so I think we could merge the PR.
That's right, I needed to adjust it in the org. I've done that and put a comment in the main ticket instructlab/dev-docs#192 for the record. |
This PR updates the constraints-dev.txt file using
tox -e constraints.