Skip to content

Conversation

@pinglin
Copy link
Member

@pinglin pinglin commented Sep 22, 2025

Because

  • The TriggerSingleReporter method was missing the same error filtering logic that exists in NewUsage and StartReporter methods
  • When GetUserAdmin fails with "users/admin" error, it should be treated as a debug message rather than an error since only Instill Core CE has the default "admin" user
  • Without this filtering, false alarm errors were being logged when the admin user doesn't exist in other Instill editions

This commit

  • Adds the same error filtering pattern to TriggerSingleReporter that already exists in NewUsage and StartReporter
  • Changes the error handling to check if the error contains "users/admin" and treats it as a debug log instead of an error log
  • Ensures consistent error handling across all three methods when dealing with the default admin user lookup
  • Prevents false alarm error logs in Instill editions that don't have the default admin user

@pinglin pinglin merged commit 1ff428f into main Sep 22, 2025
6 checks passed
@pinglin pinglin deleted the pinglin/fix-usage-add-missing-error-filtering-for-users-admin branch September 22, 2025 15:36
donch1989 pushed a commit that referenced this pull request Oct 7, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.38.5](v0.38.4...v0.38.5)
(2025-09-22)


### Bug Fixes

* **usage:** add missing error filtering for users/admin
([#777](#777))
([1ff428f](1ff428f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
donch1989 added a commit to instill-ai/instill-core that referenced this pull request Oct 7, 2025
Because
- The version of the model-backend service is not updated in the
instill-core repository.

This commit
- updates the `MODEL_BACKEND_VERSION` in the `.env` file to `0.38.5`.
- updates the `modelBackend.image.tag` in the helm chart values.yaml
file to `0.38.5`.

## Changes in model-backend
- chore(main): release 0.38.5 (instill-ai/model-backend#778)
- fix(usage): add missing error filtering for users/admin
(instill-ai/model-backend#777)

Co-authored-by: donch1989 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants