Skip to content

Fix bug when pasting value with multiple static parts in the middle #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gitim wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bug when pasting value with multiple static parts in the middle #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,13 +379,9 @@ InputMask.prototype.paste = function paste(input) {
// already have been stepped over by input(), so verify that the value
// deemed invalid by input() was the expected static character.
if (!valid) {
if (this.selection.start > 0) {
// XXX This only allows for one static character to be skipped
var patternIndex = this.selection.start - 1
if (!this.pattern.isEditableIndex(patternIndex) &&
input.charAt(i) === this.pattern.pattern[patternIndex]) {
continue
}
if (!this.pattern.isEditableIndex(i + this.pattern.firstEditableIndex) &&
input.charAt(i) === this.pattern.pattern[i + this.pattern.firstEditableIndex]) {
continue
}
extend(this, initialState)
return false
Expand Down
7 changes: 6 additions & 1 deletion test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ test('Backspace with selected range', function(t) {
})

test('Pasting', function(t) {
t.plan(10)
t.plan(11)

var mask = new InputMask({
pattern: '1111 1111 1111 1111'
Expand Down Expand Up @@ -335,6 +335,11 @@ test('Pasting', function(t) {
// Pasted input can contain static formatting characters
t.true(mask.paste('1234 1234 1234 1234'), 'Pasted value can contain static parts')
t.equal(mask.getValue(), '1234 1234 1234 1234', 'Value after paste')

mask = new InputMask({
pattern: '1111 / 1111 / 1111 / 1111'
})
t.true(mask.paste('1234 / 1234 / 1234 / 1234'), 'Pasted value can contain several static parts')
})

test('Pasting with leading static pattern in selection', function(t) {
Expand Down