Support deploying to Cloud Run #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuliooassis
approved these changes
Jan 31, 2023
tuliooassis
force-pushed
the
cloud-run
branch
from
2a17c3f to
44298ff
Compare
This reverts commit 9f8e44c.
|
Slack Thread |
stephenkrughoff
approved these changes
Feb 8, 2023
Adam-Edry
approved these changes
Feb 8, 2023
package.json
Outdated
| "https": "~1.0.0", | ||
| "https-proxy-agent": "~2.2.1", | ||
| "hummus": "~1.0.87", | ||
| "jest": "^28.1.0", |
There was a problem hiding this comment.
Jest should be a dev dependency. Are there other packages that were added as regular dependencies that should not be?
Member
There was a problem hiding this comment.
Done! Just moved the jest to dev dependencies now, but we'll keep it in mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR