Skip to content

feat: add support to missing fields on RegisterFeedback #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
figueredo wants to merge 1 commit into
base: feat-feedback-event-as-string
Choose a base branch
from
Open

feat: add support to missing fields on RegisterFeedback #236

figueredo wants to merge 1 commit into from

Conversation

@figueredo
Copy link
Contributor

@figueredo figueredo commented Jul 18, 2024 •
edited
Loading

Proposed changes

Adds support to specifying request_token and expires_at when registering a feedback.

Checklist

  • Style check and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@figueredo figueredo requested a review from racevedoo July 18, 2024 20:05
@figueredo figueredo self-assigned this Jul 18, 2024
@figueredo figueredo requested review from a team and gaabs and removed request for a team July 18, 2024 20:05
@figueredo figueredo force-pushed the feat-feedback-event-as-string branch from 65649b8 to 416299d Compare July 19, 2024 20:05
@figueredo figueredo changed the title feat: add support to expires_at on RegisterFeedback feat: add support to missing fields on RegisterFeedback Jul 19, 2024
@figueredo figueredo force-pushed the feat-feedback-expires-at branch 2 times, most recently from 73e6c75 to 44ddd16 Compare July 20, 2024 04:21
@figueredo figueredo force-pushed the feat-feedback-event-as-string branch 2 times, most recently from 977a2ba to 38f2459 Compare July 24, 2024 18:37
@figueredo
feat: add support to missing fields on RegisterFeedback
e539a0d 
Adds support to expires_at and request_token.
@figueredo figueredo force-pushed the feat-feedback-expires-at branch from 44ddd16 to e539a0d Compare July 24, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@racevedoo racevedoo racevedoo approved these changes

+1 more reviewer

@gaabs gaabs gaabs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@figueredo figueredo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@figueredo @racevedoo @gaabs