Skip to content

Conversation

@shin71
Copy link

@shin71 shin71 commented Apr 4, 2025

This commit gives user the ability to set the containerName and containerNamespace in cert-manager and the current containerName of the cert-manager in the pod seems to cert-manager-controller.

image
image
image

shin71 added 3 commits April 4, 2025 12:01
…inerNamespace in cert-manager and the current containerName of the cert-manager in the pod seems to cert-manager-controller
@imusmanmalik imusmanmalik added the enhancement New feature or request label Apr 4, 2025
@imusmanmalik
Copy link
Owner

imusmanmalik commented Apr 4, 2025

Thanks for the contribution @shin71, this is a solid improvement in terms of configurability. Just to make sure everything is covered:

Please define default values for containerName and namespace inside config.libsonnet, like so:

{
  containerName: 'cert-manager',
  namespace: 'cert-manager',
}

This would ensure backwards compatibility for users who do not pass custom values. Also, it would be good to include or adjust tests to verify both:

  • The default values work as expected when nothing is passed.
  • Custom values are respected when defined.

One more thing to consider before we merge this, the tests should ideally be adjusted to validate both behaviours introduced by this change:

  • Default behavior: Ensure that when containerName and namespace are not provided, the mixin still defaults to "cert-manager" for both. This ensures backward compatibility is preserved and existing use cases continue to work.

  • Custom configuration: Add a test case where custom containerName and namespace values are passed, and confirm they are correctly reflected in the rendered output (e.g., recording rules, alerts).

This will help ensure the change works across use cases, and won’t introduce regressions.

@shin71
Copy link
Author

shin71 commented Apr 4, 2025

@imusmanmalik
Thanks for the quick reply.
I have changed the default values . About the tests part do you want me to just test the rendering locally(which I have) and mention the process in the PR because I don't see any rendering tests in the repo?

@imusmanmalik
Copy link
Owner

@shin71 perfect and thanks again.

Unfortunately i am not able to re-run the workflow as its old now and don't have workflow dispatch enabled to re-run this manually.

We do have the tests in the repo which runs in the PR as well along with lint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants